[U-Boot] [PATCH v4] x86: baytrail: Configure FSP UPD from device tree

[Bin Meng]

Hi Simon,

On Sun, Aug 9, 2015 at 12:18 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi,
>
> On 7 August 2015 at 06:44, Bin Meng <bmeng.cn at gmail.com> wrote:
>> On Fri, Aug 7, 2015 at 8:36 PM, Andrew Bradford
>> <andrew at bradfordembedded.com> wrote:
>>> From: Andrew Bradford <andrew.bradford at kodakalaris.com>
>>>
>>> Allow for configuration of FSP UPD from the device tree which will
>>> override any settings which the FSP was built with itself.
>>>
>>> Modify the MinnowMax and BayleyBay boards to transfer sensible UPD
>>> settings from the Intel FSPv4 Gold release to the respective dts files,
>>> with the condition that the memory-down parameters for MinnowMax are
>>> also used.
>>>
>>> Signed-off-by: Andrew Bradford <andrew.bradford at kodakalaris.com>
>>> ---
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>>
>
> Acked-by: Simon Glass <sjg at chromium.org>
> Tested on minnowmax:
> Tested-by: Simon Glass <sjg at chromium.org>
>
> I found that I need to remove two properties from the minnowmax.dts:
>
> - fsp,enable-xhci needs to be removed as this does not work in U-Boot
> at present and stops EHCI from working

Ah, I thought xHCI was working on MinnowMax! Further looking at the
codes, I found you added the pci-xhci driver but is not enabled on
MinnowMax. In fact, I was trying to bring up xHCI on BayleyBay as it
does not work. I thought it might be caused by my BayTrail stepping is
pretty old on my board. But now since it does not work on MinnowMax
(which has B2 and D0 stepping), so it looks it may be a U-Boot xHCI
driver issue?

> - fsp,mrc-debug-msg needs to be removed to prevent debug information
> being displayed
>

I was using a FSPv4 debug binary and does not notice this.

> I plan to apply this with these changes - please let me know if this
> doesn't suit.
>

Regards,
Bin