[U-Boot] [PATCH v2 01/10] net: Revert "tftp: adjust settings to be suitable for 100Mbit ethernet"

Bin Meng bmeng.cn at gmail.com
Wed Aug 26 17:06:53 CEST 2015


Hi Joe,

On Wed, Aug 26, 2015 at 10:50 PM, Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> On Wed, Aug 26, 2015 at 8:17 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Commit 620776d "tftp: adjust settings to be suitable for 100Mbit ethernet"
>> causes the following error message when trying to load a file using 'tftp'
>> command via a tftp server.
>>
>>     TFTP error: 'Unsupported option(s) requested' (8)
>>
>> This is due to with commit 620776d changes, the tftp option 'timeout'
>> value is now set to zero which is an invalid value as per RFC2349 [1].
>> Valid values range between "1" and "255" seconds, inclusive. With some
>> tftp servers that strictly implement the RFC requirement, it reports
>> such an error message.
>>
>> Revert commit 620776d for RFC compliance.
>>
>> [1] https://www.ietf.org/rfc/rfc2349.txt
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>
> You should always copy the author of the patch you are reverting.

Sorry, I should have. I believe this can be handled automatically by
patman's --cc-cmd, like "--cc-cmd "./tools/patman/patman --cc-cmd
/tmp/patman.17080""? But unfortunately I never get this work.

Regards,
Bin


More information about the U-Boot mailing list