[U-Boot] [PATCH v2 10/10] x86: crownbay: Enable CONFIG_PCH_GBE

[Joe Hershberger]

Hi Bin,

On Thu, Aug 27, 2015 at 10:43 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Joe,
>
> On Wed, Aug 26, 2015 at 11:31 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Joe,
>>
>> On Wed, Aug 26, 2015 at 11:25 PM, Joe Hershberger
>> <joe.hershberger at gmail.com> wrote:
>>> Hi Bin,
>>>
>>> On Wed, Aug 26, 2015 at 8:17 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> Now that we have converted the pch_gbe driver to driver moel,
>>>> enable it on Intel Crown Bay board.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>> Acked-by: Simon Glass <sjg at chromium.org>
>>>>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Remove CONFIG_PHYLIB from crownbay.h
>>>>
>>>>  configs/crownbay_defconfig | 1 +
>>>>  include/configs/crownbay.h | 3 ---
>>>>  2 files changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
>>>> index f027faf..f328159 100644
>>>> --- a/configs/crownbay_defconfig
>>>> +++ b/configs/crownbay_defconfig
>>>> @@ -21,6 +21,7 @@ CONFIG_DM_PCI=y
>>>>  CONFIG_SPI_FLASH=y
>>>>  CONFIG_DM_ETH=y
>>>>  CONFIG_E1000=y
>>>> +CONFIG_PCH_GBE=y
>>>>  CONFIG_VIDEO_VESA=y
>>>>  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
>>>>  CONFIG_USB=y
>>>> diff --git a/include/configs/crownbay.h b/include/configs/crownbay.h
>>>> index a344c85..3153a74 100644
>>>> --- a/include/configs/crownbay.h
>>>> +++ b/include/configs/crownbay.h
>>>> @@ -49,9 +49,6 @@
>>>>  #define CONFIG_MMC_SDMA
>>>>  #define CONFIG_CMD_MMC
>>>>
>>>> -/* Topcliff Gigabit Ethernet */
>>>> -#define CONFIG_PHYLIB
>>>> -
>>>
>>> Since you added the PHYLIB config to the Kconfig, you need to run the
>>> moveconfig.py tool to convert all boards so there is not a conflict
>>> between the 2 config approaches.
>>>
>>
>> Since it is default n, so I believe there should be no conflicts. I
>> thought moveconfig causes lots of changes, which might be risky at
>> this time for this release? Do you think we can leave the PHYLIB
>> moveconfig to next release? But I may be wrong, e.g. I should trust
>> the moveconfig tool ;-)
>>
>
> Please let me know if you want me to update all boards' header and
> defconfig files with moveconfig for PHYLIB for this release.

I guess it's unnecessary for this release. At least make sure that
this doesn't cause problems on any boards with DM_ETH enabled.

-Joe