[U-Boot] [PATCH 2/2] cmd_fdt: Print the control fdt in terms of virtual memory

Albert ARIBAUD albert.u.boot at aribaud.net
Tue Feb 3 23:30:13 CET 2015


Hello Joe,

On Tue, 3 Feb 2015 16:06:07 -0600, Joe Hershberger
<joe.hershberger at ni.com> wrote:
> If you want to inspect the control device tree using the fdt command,
> the "fdt address -c" command previously unhelpfully printed the phys
> memory address of the device tree.  That address could not then be used
> to set the fdt address for inspection.

Nitpick: your commit message says what the problem is, but does not say
what solution is chosen. Granted, here understanding that from the code
is trivial, but I'd still like it if the message made it clear.

> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> 
> ---
> 
>  common/cmd_fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c
> index 51c585b..868558d 100644
> --- a/common/cmd_fdt.c
> +++ b/common/cmd_fdt.c
> @@ -111,7 +111,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  			if (!blob || !fdt_valid(&blob))
>  				return 1;
>  			printf("The address of the fdt is %#08lx\n",
> -			       control ? (ulong)blob :
> +			       control ? (ulong)map_to_sysmem(blob) :
>  					getenv_hex("fdtaddr", 0));
>  			return 0;
>  		}
> -- 
> 1.7.11.5
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



Amicalement,
-- 
Albert.


More information about the U-Boot mailing list