[U-Boot] [PATCH 1/2] cmd_fdt: Actually fix fdt command in sandbox

[Simon Glass]

Hi Joe,

On 3 February 2015 at 15:06, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Commit 90bac29a76bc8d649b41a55f2786c0abef9bb2c1 claims to fix this bug
> that was introduced in commit a92fd6577ea17751ead9b50243e3c562125cf581
> but doesn't actually make the change that the commit message describes.
>
> Actually fix the bug this time.
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> ---
>
>  common/cmd_fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg at chromium.org>

set_working_fdt_addr() is very confusing. It should take a ulong as a
parameter, not a void *.

>
> diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c
> index dc59fab..51c585b 100644
> --- a/common/cmd_fdt.c
> +++ b/common/cmd_fdt.c
> @@ -123,7 +123,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>                 if (control)
>                         gd->fdt_blob = blob;
>                 else
> -                       set_working_fdt_addr((void *)blob);
> +                       set_working_fdt_addr((void *)addr);
>
>                 if (argc >= 2) {
>                         int  len;
> --
> 1.7.11.5
>

Regards,
Simon