[U-Boot] [PATCH 3/4] sunxi: video: Add support for tl059wv5c0 lcd panels

[Ian Campbell]

On Mon, 2015-02-16 at 23:25 +0100, Hans de Goede wrote:
> Add support for the 6" 480x800 tl059wv5c0 panel used on e.g. Utoo P66 and
> Aigo M60/M608/M606 tablets.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

All 4 patches: Acked-by: Ian Campbell <ijc at hellion.org.uk>

I a couple of small comments on this one, which you can either ignore or
fixup as you commit:
> ---
>  board/sunxi/Kconfig           | 8 ++++++++
>  drivers/video/sunxi_display.c | 7 +++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index ef59e21..19e7286 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -411,6 +411,14 @@ config VIDEO_LCD_PANEL_HITACHI_TX18D42VM
>  	---help---
>  	7.85" 1024x768 Hitachi tx18d42vm LCD panel support
>  
> +config VIDEO_LCD_TL059WV5C0
> +	bool "tl059wv5c0 LCD panel"
> +	select VIDEO_LCD_PANEL_I2C
> +	select VIDEO_LCD_IF_PARALLEL
> +	---help---
> +	Say Y here to add support for the 6" 480x800 tl059wv5c0 panel used
> +	on e.g. Utoo P66 and Aigo M60/M608/M606 tablets.


"Say Y" doesn't really make sense within a choice option. Better to
follow the lead of the Hitachi panel above and '6" 480x800 tl059wv5c0
panel'. I'm not sure a non-exhaustive list of boards/tablets is useful
either -- presumably if we know to list them here we also know to enable
the option in the defconfig.

> @@ -1030,6 +1031,12 @@ static void sunxi_mode_set(const struct ctfb_res_modes *mode,
>  			mdelay(50); /* Wait for lcd controller power on */
>  			hitachi_tx18d42vm_init();
>  		}
> +		if (IS_ENABLED(CONFIG_VIDEO_LCD_TL059WV5C0)) {
> +			unsigned int orig_i2c_bus = i2c_get_bus_num();
> +			i2c_set_bus_num(CONFIG_VIDEO_LCD_I2C_BUS);

I see that you save and restore the value but it might be nice for the
relevant axp drivers to also call this using CONFIG_SYS_SPD_BUS_NUM?
(I'm assuming it is set initially to this via i2c_init_all()?)

Ian.