[U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define

Tom Rini trini at konsulko.com
Tue Sep 29 19:12:32 CEST 2015


On Tue, Sep 29, 2015 at 07:25:27PM +0300, Igor Grinberg wrote:

> ping
> 
> On 09/24/15 12:56, Igor Grinberg wrote:
> > Hi Tom,
> > 
> > On 08/26/15 17:54, Igor Grinberg wrote:
> >> CONFIG_TWL4030_POWER is a boolean define variable. It is either defined
> >> or not defined and should not have a value assigned to it.
> >> Remove the value.
> >>
> >> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
> > 
> > I think this one can also be applied, no?
> > 
> >> ---
> >>  include/configs/ti_omap3_common.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
> >> index be231a5..e399a87 100644
> >> --- a/include/configs/ti_omap3_common.h
> >> +++ b/include/configs/ti_omap3_common.h
> >> @@ -66,7 +66,7 @@
> >>  #define CONFIG_SYS_MONITOR_LEN		(256 << 10)
> >>  
> >>  /* TWL4030 */
> >> -#define CONFIG_TWL4030_POWER		1
> >> +#define CONFIG_TWL4030_POWER
> >>  
> >>  /* SPL */
> >>  #define CONFIG_SPL_TEXT_BASE		0x40200800

Reviewed-by: Tom Rini <trini at konsulko.com>

And I figured you just re-post this as part of v2 as it's trivially
correct but also a tiny thing in a bigger series.
-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150929/b35fd2a4/attachment.sig>


More information about the U-Boot mailing list