[U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define

Igor Grinberg grinberg at compulab.co.il
Wed Sep 30 09:54:37 CEST 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 09/29/15 20:12, Tom Rini wrote:
> On Tue, Sep 29, 2015 at 07:25:27PM +0300, Igor Grinberg wrote:
> 
>> ping
>>
>> On 09/24/15 12:56, Igor Grinberg wrote:
>>> Hi Tom,
>>>
>>> On 08/26/15 17:54, Igor Grinberg wrote:
>>>> CONFIG_TWL4030_POWER is a boolean define variable. It is either defined
>>>> or not defined and should not have a value assigned to it.
>>>> Remove the value.
>>>>
>>>> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
>>>
>>> I think this one can also be applied, no?
>>>
>>>> ---
>>>>  include/configs/ti_omap3_common.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
>>>> index be231a5..e399a87 100644
>>>> --- a/include/configs/ti_omap3_common.h
>>>> +++ b/include/configs/ti_omap3_common.h
>>>> @@ -66,7 +66,7 @@
>>>>  #define CONFIG_SYS_MONITOR_LEN		(256 << 10)
>>>>  
>>>>  /* TWL4030 */
>>>> -#define CONFIG_TWL4030_POWER		1
>>>> +#define CONFIG_TWL4030_POWER
>>>>  
>>>>  /* SPL */
>>>>  #define CONFIG_SPL_TEXT_BASE		0x40200800
> 
> Reviewed-by: Tom Rini <trini at konsulko.com>
> 
> And I figured you just re-post this as part of v2 as it's trivially
> correct but also a tiny thing in a bigger series.

Well, its relation is only by the affected file, so it will help me more
(less things to carry for v2) if you can apply it already.

Thanks!

- -- 
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWC5U9AAoJEBDE8YO64EfaguIP/00wC4X6lL89yIlHpWM6qGZ9
p60KzPvbmfXoa86UyWNrmGBNKkP1i86ECNnRk8CRyzTWKt9f7o9RlceLWfqIYK0G
wkAEk724G+FpYAqgTgkVB/BBF/mimm9JbjdoA5Tx58MDaK3bP5zKQ4J4a1mReZa9
fW/remBNgOtV++QGQBZMzPUWowAc4YQNZ9ZlXN0ZhSqoGprVQAsuQdJybfIIyF+i
GSctjK77ObGpwf7NLS+ft8290f1eo/Jd+KMXFs7m3OHXo+yFvjq9FbET8DGYSy2N
pANLDbxmd3Mgc1PA4XZNnGt6BJ04vNlFhWUW9I2+FZTMldegyblUSc1Fug5mWqWa
DtxgE8YSlEjLbrrgEUlZ6zk6Xmfb5Nz9ndBiNUfduOt3YOUdnR5SJThF7bjq3UXz
LN+fO6K1HK/EY8jc9qMb7Jme4hx1/pHcy4Vzx7Zh/9m4u9mZkRXJnqITxcS2+hhs
H00v3XuhTfjNybgmrunvclPFlxvicb8P7BBTDKhmPzb2mV19g+AhrmmHjIbPhvVh
QBMv0mkQsG+KYqD9ruj+OLT3xMQ99skipX3uUUY3z90u6RGMjRWKvlSrLSmr56SE
AdmnZw6Al/WTLuvi66S3WE3jmjF0f5TKBPa6uIVLyxgdC9jDJZNA1iSDIAX9s5wZ
LDwX8bcLf32c7BPKBe1/
=M25l
-----END PGP SIGNATURE-----


More information about the U-Boot mailing list