[U-Boot] Newbie SPL question for socfpga_sockit

[Marek Vasut]

On 04/06/2016 02:31 AM, George Broz wrote:
> On 5 April 2016 at 15:03, Marek Vasut <marex at denx.de> wrote:
>> On 04/05/2016 10:33 AM, Phil Reid wrote:
>>> On 27/03/2016 4:52 AM, Marek Vasut wrote:
>>>> On 03/22/2016 06:06 PM, Dinh Nguyen wrote:
>>>>>
>>>>>
>>>>> On 03/20/2016 11:42 AM, Marek Vasut wrote:
>>>>>>>
>>>>>>> Sorry, I know that doesn't help. So let's walk through my workflow.
>>>>>>> I am
>>>>>>> not using any Altera tools when I build.
>>>>>>>
>>>>>>> $make socfpga_de0_nano_soc_defconfig
>>>>>>> $make u-boot-with-spl.sfp
>>>>>>> $dd if=u-boot-with-spl.sfp of=/dev/sdb3
>>>>>>>
>>>>>>> My gcc is: arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.7.3-12ubuntu1) 4.7.3
>>>>>>>
>>>>>>> Has the board ever worked for you at all? Can you try this image:
>>>>>>>
>>>>>>> https://rocketboards.org/foswiki/view/Documentation/AtlasSoCSdCardImage
>>>>>>>
>>>>>>>
>>>>>>> Dinh
>>>>>>
>>>>>> I just ported U-Boot to another customer board. I noticed QSPI has
>>>>>> problems and USB can be flaky. That's the standard cache issue we
>>>>>> have, disabling dcache fixed that.
>>>>>>
>>>>>> I am starting to wonder whether we're hitting some corner case here.
>>>>>> Maybe we should eventually try and trace all the register reads and
>>>>>> writes generated by the DDR calibration code both in old and new SPL
>>>>>> and make a diff to see if something really did change.
>>>>>>
>>>>>> Dinh, can you share the marking on the SoC and the DRAMs on your board?
>>>>>>
>>>>>
>>>>> My SoC is:
>>>>>
>>>>> 5CSEMA4U23C6N
>>>>> CACAU1525A
>>>>>
>>>>> DRAMs are:
>>>>>
>>>>> ISSI 1510
>>>>> IS43TR16256A
>>>>> 15HBL K080
>>>>> P4482100QER2 TWN
>>>>
>>>> Thanks, that's indeed rev. C . About time I bang my head against the
>>>> desk because this is creepy.
>>>>
>>>>
>>> FYI
>>>
>>> I've just spend some time trying to update the spl / uboot / kernel &
>>> rootfs image on our
>>> Altera socdk to use for some software testing / development.
>>> Unfortunately it fails in the mem calibration process with the latest
>>> uboot most of the time.
>>> And when it does boot somtimes fails loading uboot fomr the mmc.
>>
>> Try this u-boot-socfpga/ddr branch [1] , see if it works for you.
>>
>> [1]
>> http://git.denx.de/?p=u-boot/u-boot-socfpga.git;a=shortlog;h=refs/heads/ddr
> 
> I downloaded a "snapshot" from the above link producing,
> u-boot-socfpga-1931be2.tar.gz
> 
> When I try to build for sockit or de0_nano_soc I get:
> 
>  CC      drivers/mmc/mmc-uclass.o
>   CC      drivers/mmc/dw_mmc.o
>   CC      drivers/mmc/mmc.o
>   CC      drivers/mmc/socfpga_dw_mmc.o
> drivers/mmc/socfpga_dw_mmc.c:9:28: fatal error: asm/arch/dwmmc.h: No
> such file or directory
>  #include <asm/arch/dwmmc.h>
>                             ^
> compilation terminated.
> make[1]: *** [drivers/mmc/socfpga_dw_mmc.o] Error 1
> make: *** [drivers/mmc] Error 2

Thanks for spotting this. Did you try the most basic of basic approaches:

diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
index 43a7e7e..097db81 100644
--- a/drivers/mmc/socfpga_dw_mmc.c
+++ b/drivers/mmc/socfpga_dw_mmc.c
@@ -6,7 +6,6 @@

 #include <common.h>
 #include <asm/arch/clock_manager.h>
-#include <asm/arch/dwmmc.h>
 #include <asm/arch/system_manager.h>
 #include <dm.h>
 #include <dwmmc.h>

The git tree is updated now.

Best regards,
Marek Vasut