[U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected

[Shaohui Xie]

Hi Ying,

The commit message should be more clear about what is wrong.
Like when using protocols to support 10G on MAC9 and MAC10, these
MACs should not be identified as 1G interface, otherwise, one MAC will be
Listed as two Ethernet ports, for ex. MAC9 will be listed as FM1 at TGEC1
And FM1 at DTSEC9.

Thanks,
Shaohui

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Shengzhou Liu
> Sent: Friday, April 15, 2016 3:58 PM
> To: ying.zhang at freescale.com; u-boot at lists.denx.de
> Cc: yorksun at freescale.com; Ying Zhang <b40530 at freescale.com>
> Subject: Re: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't
> be detected
> 
> 
> 
> > -----Original Message-----
> > From: Shengzhou Liu
> > Sent: Friday, April 15, 2016 3:45 PM
> > To: 'ying.zhang at freescale.com' <ying.zhang at freescale.com>; u-
> > boot at lists.denx.de
> > Cc: yorksun at freescale.com; Ying Zhang <b40530 at freescale.com>
> > Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > shouldn't be detected
> >
> >
> > > -----Original Message-----
> > > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> > > ying.zhang at freescale.com
> > > Sent: Friday, April 15, 2016 2:19 PM
> > > To: u-boot at lists.denx.de
> > > Cc: yorksun at freescale.com; Ying Zhang <b40530 at freescale.com>
> > > Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > > shouldn't be detected
> > >
> > > From: Ying Zhang <b40530 at freescale.com>
> > >
> > > FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> > >
> > > Signed-off-by: Ying Zhang <b40530 at freescale.com>
> > > ---
> > >  drivers/net/fm/t4240.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> > > ae5aca4..70887fa 100644
> > > --- a/drivers/net/fm/t4240.c
> > > +++ b/drivers/net/fm/t4240.c
> > > @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
> > port)
> > >  	if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> > >  	    ((is_serdes_configured(XFI_FM1_MAC9)) ||
> > >  	     (is_serdes_configured(XFI_FM1_MAC10))))
> > > -		return PHY_INTERFACE_MODE_XGMII;
> > > +		return PHY_INTERFACE_MODE_NONE;
> >
> > This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should
> > be configured when RCW uses the these MACs.
> > -Shengzhou
> Sorry, I missed the condition, the change is right.
> Shengzhou
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot