[U-Boot] what is the rationale for 900+ lines duplicated in common/dlmalloc.c and include/malloc.h?

Tom Rini trini at konsulko.com
Thu Apr 21 02:00:21 CEST 2016


On Sat, Apr 16, 2016 at 04:23:27AM -0400, Robert P. J. Day wrote:

>   just noticed, in common/dlmalloc.c, the sizable chunk:
> 
>     #if 0   /* Moved to malloc.h */
>     /* ---------- To make a malloc.h, start cutting here ------------ */
> 
>     ... several hundred lines ...
> 
>     #ifdef __cplusplus
>     };  /* end of extern "C" */
>     #endif
> 
>     /* ---------- To make a malloc.h, end cutting here ------------ */
>     #endif  /* 0 */                 /* Moved to malloc.h */
> 
> given that those lines appear to be duplicated in malloc.h, what is
> the purpose of them still being in dlmalloc.c? i'm just curious.

Good point.  Something that could probably be cleaned up.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160420/fc88cc0c/attachment.sig>


More information about the U-Boot mailing list