[U-Boot] what is the rationale for 900+ lines duplicated in common/dlmalloc.c and include/malloc.h?

[Robert P. J. Day]

On Wed, 20 Apr 2016, Tom Rini wrote:

> On Sat, Apr 16, 2016 at 04:23:27AM -0400, Robert P. J. Day wrote:
>
> >   just noticed, in common/dlmalloc.c, the sizable chunk:
> >
> >     #if 0   /* Moved to malloc.h */
> >     /* ---------- To make a malloc.h, start cutting here ------------ */
> >
> >     ... several hundred lines ...
> >
> >     #ifdef __cplusplus
> >     };  /* end of extern "C" */
> >     #endif
> >
> >     /* ---------- To make a malloc.h, end cutting here ------------ */
> >     #endif  /* 0 */                 /* Moved to malloc.h */
> >
> > given that those lines appear to be duplicated in malloc.h, what is
> > the purpose of them still being in dlmalloc.c? i'm just curious.
>
> Good point.  Something that could probably be cleaned up.

  i can submit a patch for that ... i can either remove the "if 0"
stuff in its entirety, or leave a short comment to the effect that
what was here has now been moved, if you think it's worth it. pick
one, and i'll put together the patch.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================