[U-Boot] [RFC PATCH] net: macb: Fix build error for CONFIG_DM_ETH enabled

Wenyou.Yang at microchip.com Wenyou.Yang at microchip.com
Mon Aug 8 15:44:42 CEST 2016



> -----Original Message-----
> From: Joe Hershberger [mailto:joe.hershberger at gmail.com]
> Sent: 2016年8月5日 1:06
> To: Wenyou Yang <wenyou.yang at atmel.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>
> Subject: Re: [U-Boot] [RFC PATCH] net: macb: Fix build error for
> CONFIG_DM_ETH enabled
> 
> On Tue, May 17, 2016 at 12:11 AM, Wenyou Yang <wenyou.yang at atmel.com>
> wrote:
> > Use the right phy_connect() prototype for CONFIGF_DM_ETH.
> > Support to get the phy interface from dt and set GMAC_UR.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > ---
> > This patch is based on the patch set,
> > [PATCH 00/18] at91: Convert Ethernet and LCD to driver model
> >         http://lists.denx.de/pipermail/u-boot/2016-May/253559.html
> >
> > Hi Simon,
> >
> > With this patch, the ethernet works on SAMA5D2 Xplained board.
> > But it includes a lot of #ifdef, I think it is not pretty.
> >
> > What is your opinions?
> 
> I think this is OK to get that board working for now. We will address all such mess
> in the future

I agree with you.

> 
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>

Thank for your Acked-by


Best Regards,
Wenyou Yang


More information about the U-Boot mailing list