[U-Boot] [PATCH] Revert "warp: Use imx_ddr_size() for calculating the DDR size"

[Otavio Salvador]

On Fri, Aug 12, 2016 at 6:07 PM, Stefano Babic <sbabic at denx.de> wrote:
> Hi Fabio,
>
> On 12/08/2016 21:38, Fabio Estevam wrote:
>> Hi Otavio,
>>
>> On Fri, Aug 12, 2016 at 3:27 PM, Otavio Salvador
>> <otavio.salvador at ossystems.com.br> wrote:
>>
>>> Why is this happening? I am fine in reverting this but we need to fix
>>> the detection. Is it due memory callibration problems?
>>
>> The problem here is that warp uses the DDR initialization from mx6sl-evk.
>>
>> From configs/mx6slevk_defconfig:
>> CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL"
>>
>> The usage of imx_ddr_size() revealed that the DDR size is not being
>> programmed correctly for the warp board.
>>
>
> That means that reverting just hides the problem.
>
>> The proper way to fix this is to create a board/warp/imximage.cfg file
>> with the DDR configuration done specifically for this board.
>>
>> Then imx_ddr_size() should work without issues for warp.
>>
>> Until this is done, better go with the revert patch for now:
>>
>> Tested-by: Fabio Estevam <fabio.estevam at nxp.com>
>
> Let's say: if there won't be any fix before the release, it is ok to
> revert this.

Agreed. We ought to fix the calibration so we don't need to hide the issue.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750