[U-Boot] [PATCH 2/3] net: davinci_emac: Round up top buffer boundaries for dcache ops

Tom Rini trini at konsulko.com
Sun Aug 14 17:47:25 CEST 2016


On Sun, Aug 14, 2016 at 03:03:16PM +0000, Karl Beldan wrote:

> check_cache_range() warns that the top boundaries are not properly
> aligned while flushing and invalidating the buffers and make these
> operations to fail.
> ATM the RX bottom boundaries are aligned by design with EMAC_RXBUF_SIZE,
> properly aligned with ARCH_DMA_MINALIGN, however the top ones are not.
> 
> This gets rid of the warnings:
> CACHE: Misaligned operation at range
> 
> Signed-off-by: Karl Beldan <karl.beldan+oss at gmail.com>
> ---
>  drivers/net/davinci_emac.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 947bfab..55461b0 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -632,7 +632,8 @@ static int davinci_eth_send_packet (struct eth_device *dev,
>  				      EMAC_CPPI_EOP_BIT);
>  
>  	flush_dcache_range((unsigned long)packet,
> -			(unsigned long)packet + length);
> +			   round_up((unsigned long)packet + length,
> +				    ARCH_DMA_MINALIGN));

It's preferred to use:
                        (unsigned long)packet + ALIGN(length, PKTALIGN)); 
here instead of ARCH_DMA_MINALIGN.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160814/8cbdeff6/attachment.sig>


More information about the U-Boot mailing list