[U-Boot] [PATCH v3]net: Wrong Initialization in davinci-emac driver

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Feb 1 17:15:34 CET 2016


Hello Vishwas,

On Mon, 1 Feb 2016 20:51:58 +0530, Vishwas Srivastava
<vishu.kernel at gmail.com> wrote:
> Author: Vishwas Srivastava <vishu.kernel at gmail.com>
> Date:   Mon Jan 25 21:28:17 2016 +0530

This is unneeded in the commit message, as the author and date are
already provided in the mail.

> Wrong Initialization in davinci emac driver

This is the title of the patch and does not need to be repeated.

> Changes for v2:
>         -cleaned up the style format
>         -addressed various comments given by Joe <joe.hershberger at ni.com>
>         on the first version of the patch.
> 
> Changes for v3:
>         - Added the missing patch part of v2

Changes should not be part of the commit message; they should appear
after the '---' line which, by the way, is completely missing here,
along with some lines at the start of the patch ; and changes should
start with the most recent change first.

Also, you are quoting the previous patch, which is unneeded.

It seems like you put this e-mail together from the output of a manual
diff rather than producing it with git send-email or patman. I suggest
re-sending (under v3 to avoid confusion) using patman, which would ease
the work of formatting the mail and managing patch versions.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list