[U-Boot] [PATCH V2 2/4] common: env_mmc: support loading env from different cards

[Stefano Babic]

Hi Peng,

On 03/02/2016 02:01, Peng Fan wrote:
> Hi Stefano,
> 
> On Tue, Feb 02, 2016 at 08:46:09PM +0100, Stefano Babic wrote:
>> Hi Peng,
>>
>> On 17/12/2015 05:43, Peng Fan wrote:
>>> Some boards support booting from different SD card slots.
>>> For example, mx6dpsabresd board supports booting from SD2,
>>> SD3, EMMC4, using different boot switch. And the index
>>> numbers are SD2(0), SD3(1), EMMC4(2).
>>> But CONFIG_SYS_MMC_ENV_DEV is hardcoded to 1(for SD3), so when
>>> booting from SD2(using 0), uboot complains "MMC: no card present",
>>> since there is no card in SD3 slot.
>>>
>>> This patch introduces a weak function which still returns
>>> CONFIG_SYS_MMC_ENV_DEV to avoid break other boards. Then
>>> different boards can implement mmc_get_env_devno to read
>>> env from the correct sd/emmc.
>>>
>>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> Cc: Tim Harvey <tharvey at gateworks.com>
>>> Cc: Hans de Goede <hdegoede at redhat.com>
>>> ---
>>>
>>
>> Tom sets this patch as deferred - then applying the rest of the series
>> makes no sense. Patchset should be rechecked later after next release.
> 
> Could you please check these three patches. I may missed to use V3, but still used V2.
> The three patches are new for the env no.
> 
> https://patchwork.ozlabs.org/patch/574586/
> https://patchwork.ozlabs.org/patch/574587/
> https://patchwork.ozlabs.org/patch/574588/
> 

I have not tested, but they looks fine - I am picking them up before my PR.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================