[U-Boot] [PATCH v2] test/py: Add option to skip SPL signature checking

[Stephen Warren]

On 02/23/2016 02:40 AM, Michal Simek wrote:
> Provide user option to skip SPL signature verification for cases where
> u-boot is build with SPL support but full U-Boot is also verified
> without SPL.
>
> If you want to support this feature please add env__spl_skipped = True
> to your boardenv configuration file.
>
> For example Xilinx Zynq is using this feature where the same U-Boot
> binary is checked with SPL and without SPL(with FSBL).
>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> Tested-by: Stephen Warren <swarren at nvidia.com>
> Acked-by: Stephen Warren <swarren at nvidia.com>

Actually, NAK now...

> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
> index d6502c6e64cb..b48d07261ff2 100644
> --- a/test/py/u_boot_console_base.py
> +++ b/test/py/u_boot_console_base.py
> @@ -307,7 +307,9 @@ class ConsoleBase(object):
>               config_spl = bcfg.get('config_spl', 'n') == 'y'
>               config_spl_serial_support = bcfg.get('config_spl_serial_support',
>                                                    'n') == 'y'
> -            if config_spl and config_spl_serial_support:
> +            config_spl_skip = self.config.env.get('env_spl_skipped',
> +                                                  False)

I was talking about renaming the Python variable config_spl_skip, not 
the boardenv_*.py variable env__spl_skipped.

The boardenv_*.py variable should be env__* to match existing variables 
in the Python file.

I was requesting that the Python variable be named env_... not 
config_... since it contains "board environment" not "config" data.

(BTW, you probably want to Cc Tom Rini on the next patch version since I 
assume he'd apply this)