[U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

Tom Rini trini at konsulko.com
Fri Feb 26 19:17:51 CET 2016


On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote:

> '#define X a | b' is better defined as '#define X (a | b)' for obvious
> reasons.
> 
> Signed-off-by: Nishanth Menon <nm at ti.com>

Reviewed-by: Tom Rini <trini at konsulko.com>

But this makes my head hurt.  Can we somehow do any of that with less
parenthesis?  Like, is this really something we must macro? Or can we
re-factor it?  I had to highlight every open/close to be happy it was
correct, which is not a good sign.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160226/1ee2f705/attachment.sig>


More information about the U-Boot mailing list