[U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

Nishanth Menon nm at ti.com
Sat Feb 27 01:13:07 CET 2016


On Fri, Feb 26, 2016 at 12:17 PM, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote:
>
>> '#define X a | b' is better defined as '#define X (a | b)' for obvious
>> reasons.
>>
>> Signed-off-by: Nishanth Menon <nm at ti.com>
>
> Reviewed-by: Tom Rini <trini at konsulko.com>
>
> But this makes my head hurt.  Can we somehow do any of that with less
> parenthesis?  Like, is this really something we must macro? Or can we
> re-factor it?  I had to highlight every open/close to be happy it was
> correct, which is not a good sign.

I will try and give it a shot and repost - yeah - it was pretty
convoluted in the first place might be changing it to a static inline
might be a simpler approach..


-- 
---
Regards,
Nishanth Menon


More information about the U-Boot mailing list