[U-Boot] [PATCH] powerpc/mpc85xx: Fix SPL_BUILD compilation by adding CONFIG_USB_EHCI_FSL flag

[york sun]

On 07/04/2016 08:38 PM, Sriram Dash wrote:
>> From: Marek Vasut [mailto:marex at denx.de]
>> On 07/04/2016 01:11 PM, Sriram Dash wrote:
>>> Commit 9262367 moved USB errata workaround to a C file but didn't
>>> build it for SPL targets. The EHCI errata should be applied/checked
>>> only when EHCI is defined.
>>>
>>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>
>>> Signed-off-by: Sriram Dash <sriram.dash at nxp.com>
>>> ---
>>>   arch/powerpc/include/asm/config_mpc85xx.h | 32
>>> +++++++++++++++++++++++++++++--
>>
>> So why don't you fix arch/powerpc/cpu/mpc85xx/cmd_errata.c instead of adding
>> zillion ifdefs into the config_mpc85xx.h ?
>>
>
> Hello Marek,
>
> The phy errata is applied at cpu init time for some boards. Due to this, the code
> has been added in the file arch/powerpc/cpu/mpc85xx/cpu_init.c also. Now, this
> file is also required for SPL build. Hence, rather than fixing in every file currently
> and the future implementations, I am thinking of fixing this at a common place.
>

Let's think from another angle. What causes this issue? Some functions 
are called for SPL build. Do we need those functions? Earlier I thought 
we need some USB workaround for SPL. But that is not the case. The 
normal version of U-Boot can implement those workaround so we don't have 
to have them for SPL. So is the cmd_errata. Now I think Ed's simple fix 
makes more sense. It's getting close to 2016.07 release. Let's test more 
with the new fix proposed by Ed. Please don't hesitate to send a new 
patch if you have other ideas.

York