[U-Boot] [PATCH 1/2] x86: Add DFI BT700 BayTrail board support

[Simon Glass]

Hi Stefan,

On 13 July 2016 at 00:04, Stefan Roese <sr at denx.de> wrote:
> This patch adds support for the DFI BayTrail BT700 QSeven SoM installed
> on the DFI Q7X-151 baseboard. The baseboard is equipped with the Nuvoton
> NCT6102D Super IO chip providing the UART as console.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> ---
>  arch/x86/Kconfig                          |   4 +
>  arch/x86/dts/Makefile                     |   1 +
>  arch/x86/dts/dfi-bt700-q7x-151.dts        |  22 +++
>  arch/x86/dts/dfi-bt700.dtsi               | 309 ++++++++++++++++++++++++++++++
>  board/dfi/Kconfig                         |  25 +++
>  board/dfi/dfi-bt700/Kconfig               |  28 +++
>  board/dfi/dfi-bt700/MAINTAINERS           |   8 +
>  board/dfi/dfi-bt700/Makefile              |   8 +
>  board/dfi/dfi-bt700/acpi/mainboard.asl    |  13 ++
>  board/dfi/dfi-bt700/dfi-bt700.c           |  30 +++
>  board/dfi/dfi-bt700/dsdt.asl              |  14 ++
>  board/dfi/dfi-bt700/start.S               |   9 +
>  configs/dfi-bt700-internal-uart_defconfig |  61 ++++++
>  configs/dfi-bt700-q7x-151_defconfig       |  63 ++++++
>  include/configs/dfi-bt700.h               |  74 +++++++
>  15 files changed, 669 insertions(+)
>  create mode 100644 arch/x86/dts/dfi-bt700-q7x-151.dts
>  create mode 100644 arch/x86/dts/dfi-bt700.dtsi
>  create mode 100644 board/dfi/Kconfig
>  create mode 100644 board/dfi/dfi-bt700/Kconfig
>  create mode 100644 board/dfi/dfi-bt700/MAINTAINERS
>  create mode 100644 board/dfi/dfi-bt700/Makefile
>  create mode 100644 board/dfi/dfi-bt700/acpi/mainboard.asl
>  create mode 100644 board/dfi/dfi-bt700/dfi-bt700.c
>  create mode 100644 board/dfi/dfi-bt700/dsdt.asl
>  create mode 100644 board/dfi/dfi-bt700/start.S
>  create mode 100644 configs/dfi-bt700-internal-uart_defconfig
>  create mode 100644 configs/dfi-bt700-q7x-151_defconfig
>  create mode 100644 include/configs/dfi-bt700.h

Reviewed-by: Simon Glass <sjg at chromium.org>

nit below

[...]

> diff --git a/board/dfi/Kconfig b/board/dfi/Kconfig
> new file mode 100644
> index 0000000..1e4f90c
> --- /dev/null
> +++ b/board/dfi/Kconfig
> @@ -0,0 +1,25 @@
> +#
> +# Copyright (C) 2015, Bin Meng <bmeng.cn at gmail.com>
> +#
> +# SPDX-License-Identifier:     GPL-2.0+
> +#
> +
> +if VENDOR_DFI
> +
> +choice
> +       prompt "Mainboard model"
> +       optional
> +
> +config TARGET_DFI_BT700
> +       bool "DFI BT700 BayTrail"
> +       help
> +         Some nice text here (test-only!!!!)

Yes please!

> +
> +         Note that PCIE_ECAM_BASE is set up by the FSP so the value used
> +         by U-Boot matches that value.
> +
> +endchoice
> +
> +source "board/dfi/dfi-bt700/Kconfig"
> +
> +endif

Regards,
Simon