[U-Boot] [PATCH 8/9] power: pmic: add Ricoh RN5T567 PMIC support

[Simon Glass]

Hi Stefan,

On 14 July 2016 at 22:43, Stefan Agner <stefan at agner.ch> wrote:
> Hi Simon,
>
> On 2016-07-14 20:19, Simon Glass wrote:
>> Hi Stefan,
>>
>> On 13 July 2016 at 00:10, Stefan Agner <stefan at agner.ch> wrote:
>>> On 2016-07-03 16:18, Simon Glass wrote:
>>>> Hi,
>>>>
>>>> On 3 July 2016 at 13:33, Stefan Agner <stefan at agner.ch> wrote:
>>>>> From: Stefan Agner <stefan.agner at toradex.com>
>>>>>
>>>>> Add power driver for Ricoh PMIC used on Colibri iMX7.
>>>>>
>>>>> Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
>>>>> Acked-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>>>> ---
>>>>>
>>>>>  drivers/power/pmic/Makefile       |   1 +
>>>>>  drivers/power/pmic/pmic_rn5t567.c |  32 +++++++++++
>>>>>  include/power/rn5t567_pmic.h      | 115 ++++++++++++++++++++++++++++++++++++++
>>>>>  3 files changed, 148 insertions(+)
>>>>>  create mode 100644 drivers/power/pmic/pmic_rn5t567.c
>>>>>  create mode 100644 include/power/rn5t567_pmic.h
>>>>
>>>> Shouldn't this use driver model?
>>>
>>> Looked into this a bit more in detail.
>>>
>>> Afaict, using DM for PMIC would need to use DM for I2C too. The current
>>> driver supports I2C DM only when using device tree, plus it would also
>>> require DM for GPIOs, all that is currently not used by the i.MX 7
>>> platform.
>>>
>>> I would prefer to stick with the current implementation until that is
>>> sorted, is that acceptable for now?
>>
>> Yes, but I hope you can resolve this quickly. It is not good to add
>> new code to old frameworks as they get harder to remove.
>
> I already sent v2 without this patch. I figured since the PMIC code is
> not essential (only used for reset currently) I might as well leave it
> out now and do it right in a second patch set.
>
> So hope to get the rest in soon :-)

OK, sounds good.

Regards,
Simon