[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Simon Glass]

On 22 July 2016 at 08:02, Michal Simek <michal.simek at xilinx.com> wrote:
> On 22.7.2016 15:33, Simon Glass wrote:
>> Hi Michal,
>>
>> On 22 July 2016 at 01:13, Michal Simek <monstr at monstr.eu> wrote:
>>> Hi Simon and Stephen,
>>>
>>> On 20.7.2016 17:51, Stephen Warren wrote:
>>>> On 07/20/2016 08:19 AM, Simon Glass wrote:
>>>>> +Stephen
>>>>>
>>>>> On 18 July 2016 at 00:49, Michal Simek <michal.simek at xilinx.com> wrote:
>>>>>> Getting this error:
>>>>>> Zynq> sb load hostfs - 100
>>>>>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>>>>>> Unknown command 'sb' - try 'help'
>>>>>>
>>>>>> because sb command is present only for Sandbox
>>>>>> obj-$(CONFIG_SANDBOX) += host.o
>>>>>>
>>>>>> that's why mark this test to be run only at Sandbox
>>>>>>
>>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>>>> ---
>>>>>>
>>>>>>   test/py/tests/test_vboot.py | 1 +
>>>>>>   1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>>>>>> index c77989591c7e..92b4eccad808 100644
>>>>>> --- a/test/py/tests/test_vboot.py
>>>>>> +++ b/test/py/tests/test_vboot.py
>>>>>> @@ -29,6 +29,7 @@ import pytest
>>>>>>   import sys
>>>>>>   import u_boot_utils as util
>>>>>>
>>>>>> + at pytest.mark.boardspec('sandbox')
>>>>>>   @pytest.mark.buildconfigspec('fit_signature')
>>>>>
>>>>> Can we have both conditions, or does it only work as an OR?
>>>>
>>>> I believe marks are conditions that must be individually satisfied, so
>>>> when there are multiple marks, it's treated like an AND, which I imagine
>>>> is the desired thing here.
>>>>
>>>
>>> ACK then?
>>
>> Can you add both conditions?
>
> Sorry I don't get it. Origin there is condition that fit_signature needs
> to be enabled. And this patch adds one more when sandbox is enabled.
>
> It means vboot test runs on sandbox when fit_signature is enabled.

OK that sounds good, thanks.

Acked-by: Simon Glass <sjg at chromium.org>