[U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional

Wolfgang Denk wd at denx.de
Tue Jul 26 08:56:05 CEST 2016


Dear "R, Vignesh",

In message <a210f61e-bf51-a946-013c-dd98fd9a17b0 at ti.com> you wrote:
> 
> >> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
> >>  		return -ENOENT;
> >>  	}
> >>  
> >> +
> >> +	num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
> > 
> > Extra blank line added.
> 
> I added blank line for readability. So, that code block handling
> toggling of "mode-gpios" is separated from the rest. I can remove that
> if that seems unnecessary.

There was already a blank line which provides enough separation. No
need to have multiple consecutive blank lines.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
                        - Terry Pratchett, _The Dark Side of the Sun_


More information about the U-Boot mailing list