[U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional

R, Vignesh vigneshr at ti.com
Tue Jul 26 08:58:12 CEST 2016



On 7/26/2016 12:26 PM, Wolfgang Denk wrote:
> Dear "R, Vignesh",
> 
> In message <a210f61e-bf51-a946-013c-dd98fd9a17b0 at ti.com> you wrote:
>>
>>>> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
>>>>  		return -ENOENT;
>>>>  	}
>>>>  
>>>> +
>>>> +	num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
>>>
>>> Extra blank line added.
>>
>> I added blank line for readability. So, that code block handling
>> toggling of "mode-gpios" is separated from the rest. I can remove that
>> if that seems unnecessary.
> 
> There was already a blank line which provides enough separation. No
> need to have multiple consecutive blank lines.

Sorry, will clean that up in v2. Thanks!

Regards
Vignesh


More information about the U-Boot mailing list