[U-Boot] [PATCH] imx: ventana: enable splashscreen support

[Tim Harvey]

On Thu, Jul 28, 2016 at 3:37 AM, Stefano Babic <sbabic at denx.de> wrote:
>
> Hi Tim,
>
> On 15/07/2016 16:17, Tim Harvey wrote:
> > Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> > ---
> >  include/configs/gw_ventana.h |   7 ++++---
> >  tools/logos/gateworks.bmp    | Bin 0 -> 56202 bytes
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> >  create mode 100644 tools/logos/gateworks.bmp
> >
> > diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> > index 1bd13fe..61242a1 100644
> > --- a/include/configs/gw_ventana.h
> > +++ b/include/configs/gw_ventana.h
> > @@ -191,15 +191,15 @@
> >  #define CONFIG_CFB_CONSOLE
> >  #define CONFIG_VGA_AS_SINGLE_DEVICE
> >  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
> > -#define CONFIG_VIDEO_BMP_RLE8
> > -#define CONFIG_SPLASH_SCREEN
> > -#define CONFIG_BMP_16BPP
> >  #define CONFIG_VIDEO_LOGO
> >  #define CONFIG_IPUV3_CLK          260000000
> >  #define CONFIG_CMD_HDMIDETECT
> >  #define CONFIG_CONSOLE_MUX
> >  #define CONFIG_IMX_HDMI
> >  #define CONFIG_IMX_VIDEO_SKIP
> > +#define CONFIG_VIDEO_BMP_LOGO
> > +#define CONFIG_SPLASH_SCREEN_ALIGN
> > +#define CONFIG_HIDE_LOGO_VERSION  /* Custom config to hide U-boot version */
> >
> >  /* Miscellaneous configurable options */
> >  #define CONFIG_HWCONFIG
> > @@ -274,6 +274,7 @@
> >
> >  #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
> >       "pcidisable=1\0" \
> > +     "splashpos=m,m\0" \
> >       "usb_pgood_delay=2000\0" \
> >       "console=ttymxc1\0" \
> >       "bootdevs=usb mmc sata flash\0" \
> > diff --git a/tools/logos/gateworks.bmp b/tools/logos/gateworks.bmp
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..01edb7cedf46c3441619213b6baf33410055601f
>
> This is done on several boards, but I would ask if this is strictly
> required. You can already display a bmp on the screen, and it is a more
> flexible way as linked the image with U-Boot. Do you really need
> CONFIG_VIDEO_BMP_LOGO ?
>
> Best regards,
> Stefano Babic
>

Stefano,

I think your talking about:

#define CONFIG_CMD_BMP
              - Adds support for displaying raw bmp images.
#define CONFIG_SPLASH_SCREEN_ALIGN
              - If this option is set the splash image (or bmp logo)
can be freely positioned
                on the screen. Environment variable "splashpos"
specifies the position as
                "x,y". If a positive number is given it is used as
number of pixel from
                left/top. If a negative number is given it is used as
number of pixel from
                right/bottom. You can also specify 'm' as x and/or y
to center the image.

While this method of a splash-screen is indeed very flexible it has
the downside of bringing up the splash a little later. The other
downside is that you have to either load it from the filesystem (which
creates an even longer delay) or stick it in a raw partition which
means changing an already established partitioning scheme.

Is it generally frowned upon to add hard-coded logo's as I've done
and/or is there a move to replace hard-coded logos with loadable ones?
It appears there are 16 of them in tools/logos although most appear to
be imx6 or other fsl based boards.

Regards,

Tim