[U-Boot] [PATCH] imx: ventana: enable splashscreen support

[Stefano Babic]

Hi Tim,

On 28/07/2016 23:30, Tim Harvey wrote:

>>
>> This is done on several boards, but I would ask if this is strictly
>> required. You can already display a bmp on the screen, and it is a more
>> flexible way as linked the image with U-Boot. Do you really need
>> CONFIG_VIDEO_BMP_LOGO ?
>>
>> Best regards,
>> Stefano Babic
>>
> 
> Stefano,
> 
> I think your talking about:
> 
> #define CONFIG_CMD_BMP
>               - Adds support for displaying raw bmp images.
> #define CONFIG_SPLASH_SCREEN_ALIGN
>               - If this option is set the splash image (or bmp logo)
> can be freely positioned
>                 on the screen. Environment variable "splashpos"
> specifies the position as
>                 "x,y". If a positive number is given it is used as
> number of pixel from
>                 left/top. If a negative number is given it is used as
> number of pixel from
>                 right/bottom. You can also specify 'm' as x and/or y
> to center the image.
> 
> While this method of a splash-screen is indeed very flexible it has
> the downside of bringing up the splash a little later.

This is absolutely true. What I like about it is the strict distinction
between code (U-Boot) and data (the bitmap).

> The other
> downside is that you have to either load it from the filesystem (which
> creates an even longer delay) or stick it in a raw partition which
> means changing an already established partitioning scheme.

Right, this is also correct.

> 
> Is it generally frowned upon to add hard-coded logo's as I've done
> and/or is there a move to replace hard-coded logos with loadable ones?
> It appears there are 16 of them in tools/logos

I know, I have just asked if the 17th could be avoided...

> although most appear to
> be imx6 or other fsl based boards.

Right - I do not block patches asking for logo, but I try at least once
to convince to use another method.

IMHO there should be at least a way to add an out-of-tree logo, using a
variable for instance. I never liked to add binary blob to the tree.
Anyway, gw_ventana will be the 17th board with logo :-)


Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================