[U-Boot] [PATCH 30/69] x86: gpio: Correct GPIO setup ordering

Bin Meng bmeng.cn at gmail.com
Fri Mar 11 06:57:27 CET 2016


On Fri, Mar 11, 2016 at 1:55 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass <sjg at chromium.org> wrote:
>> The Intel GPIO driver can set up the GPIO pin mapping when the first GPIO
>> is probed. However, it assumes that the first GPIO to be probed is in the
>> first GPIO bank. If this is not the case then the init will write to the
>> wrong registers.
>>
>> Fix this. Also add a note that this code is deprecated. We should move to
>> using device tree instead.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  arch/x86/include/asm/gpio.h    | 5 +++++
>>  drivers/gpio/intel_ich6_gpio.c | 4 +++-
>>  2 files changed, 8 insertions(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86/next, thanks!


More information about the U-Boot mailing list