[U-Boot] [PATCH 1/2][v2] driver: net: ldpaa_eth: Add support of PHY framework

[york sun]

On 02/24/2016 03:32 AM, Prabhakar Kushwaha wrote:
> This patch integrate DPAA2 ethernet driver existing PHY framework.
> 
> Call phy_connect and phy_config as per available DPMAC id defined
> in SerDes Protcol.
> 
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava at nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> ---
> Changes for v2: Incorporated Joe Hershberger's comments
> 

Since Joe didn't comment on this version, I presume he is OK with this one.

<snip>

> @@ -914,15 +970,12 @@ static int ldpaa_eth_netdev_init(struct eth_device *net_dev,
>  	net_dev->halt = ldpaa_eth_stop;
>  	net_dev->send = ldpaa_eth_tx;
>  	net_dev->recv = ldpaa_eth_pull_dequeue_rx;
> -/*
> -	TODO: PHY MDIO information
> -	priv->bus = info->bus;
> -	priv->phyaddr = info->phy_addr;
> -	priv->enet_if = info->enet_if;
> -*/
>  
> -	if (init_phy(net_dev))
> -		return 0;
> +#ifdef CONFIG_PHYLIB
> +	err = init_phy(net_dev); 

Extra white space at the end of line. No need to respin. I can fix this when
merging.

> +	if (err < 0)
> +		return err;
> +#endif
>  
>  	err = eth_register(net_dev);
>  	if (err < 0) {
> 

York