[U-Boot] [PATCH V3] fsl: esdhc: support driver model

Peng Fan van.freenix at gmail.com
Mon Mar 28 03:14:50 CEST 2016


Hi Eric,

On Sun, Mar 27, 2016 at 11:18:00AM -0700, Eric Nelson wrote:
>Hi Peng,
>
>On 03/27/2016 07:57 AM, Peng Fan wrote:
>> On Fri, Mar 25, 2016 at 01:12:39PM -0700, Eric Nelson wrote:
>>> On 03/24/2016 11:16 PM, Peng Fan wrote:
>>>> Support Driver Model for fsl esdhc driver.
>>>>
>>>> 1. Introduce a new structure struct fsl_esdhc_priv
>>>> 2. Refactor fsl_esdhc_initialize which is originally used by board code.
>>>>    - Introduce fsl_esdhc_init to be common usage for DM and non-DM
>>>>    - Introduce fsl_esdhc_cfg_to_priv to build the bridge for non-DM part.
>>>>    - The original API for board code is still there, but we use
>>>>      'fsl_esdhc_cfg_to_priv' and 'fsl_esdhc_init' to serve it.
>>>> 3. All the functions are changed to use 'struct fsl_esdhc_priv', except
>>>>    fsl_esdhc_initialize.
>>>> 4. Since clk driver is not implemented, use mxc_get_clock to geth
>>>>    the clk and fill 'priv->sdhc_clk'.
>>>>
>>>> Has been tested on i.MX6UL 14X14 EVK board:
>>>> "
>>>> =>dm tree
>>>> ....
>>>>  simple_bus  [ + ]    |   `-- aips-bus at 02100000
>>>>   mmc        [ + ]    |       |-- usdhc at 02190000
>>>>   mmc        [ + ]    |       |-- usdhc at 02194000
>>>> ....
>>>> => mmc list
>>>> FSL_SDHC: 0 (SD) 
>>>> FSL_SDHC: 1 (SD)
>>>> "
>>>>
>>>
>>> After pulling in device tree files from the mainline kernel, I was able
>>> to test this on a SABRE Lite, so you can add my:
>>>
>>> Tested-By: Eric Nelson <eric at nelint.com>
>> 
>> Thanks, Eric.
>> 
>
>Thank you for adding this support.
>
>>>
>>> Is somebody prepping patches to pull in support for i.MX6DQ?
>> 
>> I can not follow you on this? you mean adding dts files for i.MX6DQ or else?
>>
>
>Yes, or at least the .dtsi and .h files from arch/arm/boot/dts/.
>
>Your i.MX6UL patch pulled in the files needed for UL, and the same
>is needed for i.MX6DQ, i.MX6SX and such.
>
>I have a patch pulling i.MX6DQ files from linux-stable (4.4), but

That's great.

>don't want to jump in the middle if somebody else is doing this.

I have not began this. If you have patches, feel free to post them out:)

Thanks,
Peng.
>
>Regards,
>
>
>Eric


More information about the U-Boot mailing list