[U-Boot] [PATCHv5 4/4] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Julian Scheel]

On 06.09.2016 20:58, Stephen Warren wrote:
> On 09/06/2016 12:14 PM, Julian Scheel wrote:
>> On 06.09.16 19:15, Stephen Warren wrote:
>>> On 09/05/2016 07:29 AM, Julian Scheel wrote:
>>>> Add support for platforms based on the Meerkat COM module. Includes
>>>> support
>>>> for the minimal reference platform called Kein Baseboard, which in
>>>> fact is
>>>> sufficient to run most existing Meerkat carriers.
>
>>>> diff --git a/board/avionic-design/common/pinmux-config-meerkat.h
>>>> b/board/avionic-design/common/pinmux-config-meerkat.h
>>>
>>>> +/*
>>>> + * Copyright (c) 2014, NVIDIA CORPORATION. All rights reserved.
>>>> + * Copyright (c) 2015, Avionic Design GmbH
>>>> + *
>>>> + * SPDX-License-Identifier: GPL-2.0+
>>>> + */
>>>
>>> Can you please also add support for this board to tegra-pinmux-scripts,
>>> so that anyone can generate this file? That will also allow you to
>>> re-generate the file using the latest version of tegra-pinmux-scripts
>>> which will add (a) the missing "this file is auto-generated" notice, (b)
>>> the GPIO initialization table, (c) the MIPI padctl initialization table.
>>
>> I'll discuss this internally. We have never used those scripts at all,
>> but did handwrite this code, based from Jetson code.
>
> Hmm. Do you use the Excel pinmux spreadsheet that NVIDIA syseng
> supplies? That performs a variety of error-checking, so I'd certainly
> advocate using that. If you do, then supporting tegra-pinmux-script is a
> simple matter of saving the spreadsheet as CSV and running the import
> script in tegra-pinmux-scripts. If not, I worry that the spreadsheet's
> error-checking rules haven't been validated.

No, we do not use that spreadsheet, but did all pinmux and gpio 
configuration manually. This pinmux has actually matured over more than 
2 years of usage now, so I'm pretty confident it's fine.
But I'll discuss once more whether we can fill the magic excel sheet and 
use tegra-pinmux-scripts.

>>>> +CONFIG_USB_STORAGE=y
>>>
>>> For Jetson TK1, this is defined in include/configs/jetson-tk1.h. I'd
>>> expect the two board configs to work the same way.
>>
>> Actually we have moved this to defconfig, as we decided that all options
>> that are Kconfig options by now shall be selectable via Kconfig by the
>> user.
>
> Who's "we" here; has this conversion happened in mainline? If so, it
> looks like the author of the conversion commit forgot to convert all the
> existing configuration headers and defconfigs, so someone should go back
> and fix up that commit. If the conversion hasn't happened in mainline, I
> imagine it would be welcome so feel free to send it, but if this series
> gets submitted before the conversion is submitted, it can't assume the
> conversion has happened.

Sorry the wording might have been misleading. In this case "we" refers 
to Avionic Design developers. And the discussion was not meant to be 
applicable to u-boot in general, but for our board. We simply found it 
to be useful to allow a maximum grade of u-boot customisation without 
having to change source files.
If you would like to have this discussed in general beforehands, I'd be 
happy to start the discussion on the list. But in that case we might 
resubmit the patch, having the config options synced with jetson-tk1.h, 
just to get these patches finally in.

-Julian