[U-Boot] [PATCHv5 4/4] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Stephen Warren]

On 09/07/2016 12:08 AM, Julian Scheel wrote:
> On 06.09.2016 20:58, Stephen Warren wrote:
>> On 09/06/2016 12:14 PM, Julian Scheel wrote:
>>> On 06.09.16 19:15, Stephen Warren wrote:
>>>> On 09/05/2016 07:29 AM, Julian Scheel wrote:
>>>>> Add support for platforms based on the Meerkat COM module. Includes support
>>>>> for the minimal reference platform called Kein Baseboard, which in fact is
>>>>> sufficient to run most existing Meerkat carriers.

>>>>> +CONFIG_USB_STORAGE=y
>>>>
>>>> For Jetson TK1, this is defined in include/configs/jetson-tk1.h. I'd
>>>> expect the two board configs to work the same way.
>>>
>>> Actually we have moved this to defconfig, as we decided that all options
>>> that are Kconfig options by now shall be selectable via Kconfig by the
>>> user.
>>
>> Who's "we" here; has this conversion happened in mainline? If so, it
>> looks like the author of the conversion commit forgot to convert all the
>> existing configuration headers and defconfigs, so someone should go back
>> and fix up that commit. If the conversion hasn't happened in mainline, I
>> imagine it would be welcome so feel free to send it, but if this series
>> gets submitted before t conversion is submitted, it can't assume the
>> conversion has happened.
>
> Sorry the wording might have been misleading. In this case "we" refers
> to Avionic Design developers. And the discussion was not meant to be
> applicable to u-boot in general, but for our board. We simply found it
> to be useful to allow a maximum grade of u-boot customisation without
> having to change source files.
> If you would like to have this discussed in general beforehands, I'd be
> happy to start the discussion on the list. But in that case we might
> resubmit the patch, having the config options synced with jetson-tk1.h,
> just to get these patches finally in.

Hmm. It looks like CONFIG_USB_STORAGE is defined in Kconfig in mainline, 
so this patch (at least this part) is actually OK. The patch which added 
it to Kconfig in mainline didn't convert all the board config files 
properly, which is why it's still set in many include/configs/*.h. I'll 
contact the author of that patch...