[U-Boot] [PATCHv5 4/4] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Julian Scheel]

On 06.09.2016 19:15, Stephen Warren wrote:
>> diff --git a/board/avionic-design/common/meerkat.c
>> b/board/avionic-design/common/meerkat.c
>
>> +void pinmux_init(void)
>> +{
>> +    pinmux_set_tristate_input_clamping();
>
> That should be pinmux_clear_tristate_input_clamping();
>
> gpio_config_table() is missing here.

I checked back our internal history. In fact we had this first (starting 
from Jetson TK1 as base), but later on removed it. The reason for 
removing it, was the assumption that whenever a driver wants to use a 
GPIO it will request it anyway, so that it will be confiured correctly. 
As this init code is generic for our SoM there is no predefined 
functionality for certain GPIOs which would make sense to preinit in the 
bootloader.
In fact we even had some issues when the init was there because 
customers did not expect the pin to be a GPIO and wondered why a certain 
special function did not work as expected.

Do you see any other reason why a gpio init would be really needed here?

-Julian