[U-Boot] [PATCH v2 0/2] Detect and reject new ad-hoc CONFIG options

[Tom Rini]

On Tue, Sep 13, 2016 at 07:35:42AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On 13 September 2016 at 07:16, Tom Rini <trini at konsulko.com> wrote:
> > On Mon, Sep 12, 2016 at 11:20:00PM -0600, Simon Glass wrote:
> >
> >> Despite the availability of Kconfig, the number of ad-hoc CONFIG options in
> >> U-Boot is still at over 8000.
> >>
> >> In February 2015 (commit 741e58e0) there were around 8387 ad-hoc CONFIGs.
> >> As of this patch there are about 8336, only a little fewer.
> >>
> >> One problem is that new ones are still being added, admittedly at a slower
> >> rate. This series adds a Makefile check to detect that and produce a build
> >> error. This provides immediate feedback that new CONFIG options should go in
> >> Kconfig.
> >>
> >> Changes in v2:
> >> - Rebase to mainline
> >> - Fix scripts so that there are no errors
> >> - Add the 'build-whitelist.sh' script to the tree
> >>
> >> Simon Glass (2):
> >>   Kconfig: Add a whitelist of ad-hoc CONFIG options
> >>   Makefile: Give a build error if ad-hoc CONFIG options are added
> >
> > OK, this is still a little fragile.  When I do:
> > ./tools/buildman/buildman -b master --force-build --step 0 \
> >  -SCdvel 'avr32|nds32|bfin|m68k|microblaze|or32|sh4|sparc|mips|mips64|xtensa'
> >
> > vs kconfig-working2 I'm seeing a bunch of failures:
> > +(M5475GFE) make[1]: *** [no_new_adhoc_configs_check] Error 1
> > +(M5475GFE) make: *** [sub-make] Error 2
> 
> Yes it looks like I was testing it incorrectly, relying on running on
> from the SPL series. One problem is that it misses configs with lower
> case which are defined in Kconfig and then used. I've updated
> u-boot-dm/kconfig-working2 to deal with that.
> 
> I'll take another look at this and have an update out today. But we
> can decouple this from the painful SPL series if you like, since in
> principle we can run the generation script to create the first of the
> two patches.

Yes, we can de-couple this.  However, you might want to take a look at
say xtensa as in my check with before/after kconfig-working2 there's a
tiny size difference and I don't see that normally for a Kconfig
migration.  I'm doing my arm/powerpc build now to see if there's a
similar set of size changes there and will then start poking at map
files.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160913/2d546807/attachment.sig>