[U-Boot] [PATCH v4 3/3] armv8: ls1088aqds: Add support of LS1088AQDS

[York Sun]

On 08/17/2017 10:45 PM, Ashish Kumar wrote:

<snip>

> +void ls1088a_handle_phy_interface_sgmii(int dpmac_id)
> +{
> +	struct mii_dev *bus;
> +	struct ccsr_gur __iomem *gur = (void *)CONFIG_SYS_FSL_GUTS_ADDR;
> +	u32 serdes1_prtcl, cfg;
> +
> +	cfg = in_le32(&gur->rcwsr[FSL_CHASSIS3_SRDS1_REGSR - 1]) &
> +				FSL_CHASSIS3_SRDS1_PRTCL_MASK;
> +	cfg >>= FSL_CHASSIS3_SRDS1_PRTCL_SHIFT;
> +	serdes1_prtcl = serdes_get_number(FSL_SRDS_1, cfg);
> +
> +	int *riser_phy_addr;
> +	char *env_hwconfig = getenv("hwconfig");

getenv() is no longer used. See commit 00caae6d47. Please rebase your code.

> +
> +	if (hwconfig_f("xqsgmii", env_hwconfig))
> +		riser_phy_addr = &xqsgii_riser_phy_addr[0];
> +	else
> +		riser_phy_addr = &sgmii_riser_phy_addr[0];
> +

Do you run this function when U-Boot runs in flash? If not, you should 
consider hwconfig() instead of hwconfig_f().

York