[U-Boot] [v3, 1/3] mmc: fsl_esdhc: move 'status' property fixup into a weak function
Y.B. Lu
yangbo.lu at nxp.com
Thu Jan 12 02:42:44 CET 2017
Hi York,
Any comments on this patchset?
Thanks a lot.
Best regards,
Yangbo Lu
> -----Original Message-----
> From: Yangbo Lu [mailto:yangbo.lu at nxp.com]
> Sent: Thursday, December 08, 2016 11:42 AM
> To: u-boot at lists.denx.de
> Cc: york sun; Y.B. Lu
> Subject: [v3, 1/3] mmc: fsl_esdhc: move 'status' property fixup into a
> weak function
>
> Move fdt fixup of 'status' property into a weak function. This allows
> board to define 'status' fdt fixup by themselves.
>
> Signed-off-by: Yangbo Lu <yangbo.lu at nxp.com>
> ---
> Changes for v2:
> - None
> Changes for v3:
> - None
> ---
> drivers/mmc/fsl_esdhc.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
> 9796d39..68de04e 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -908,17 +908,26 @@ void mmc_adapter_card_type_ident(void) #endif
>
> #ifdef CONFIG_OF_LIBFDT
> -void fdt_fixup_esdhc(void *blob, bd_t *bd)
> +__weak int esdhc_status_fixup(void *blob, const char *compat)
> {
> - const char *compat = "fsl,esdhc";
> -
> #ifdef CONFIG_FSL_ESDHC_PIN_MUX
> if (!hwconfig("esdhc")) {
> do_fixup_by_compat(blob, compat, "status", "disabled",
> - 8 + 1, 1);
> - return;
> + sizeof("disabled"), 1);
> + return 1;
> }
> #endif
> + do_fixup_by_compat(blob, compat, "status", "okay",
> + sizeof("okay"), 1);
> + return 0;
> +}
> +
> +void fdt_fixup_esdhc(void *blob, bd_t *bd) {
> + const char *compat = "fsl,esdhc";
> +
> + if (esdhc_status_fixup(blob, compat))
> + return;
>
> #ifdef CONFIG_FSL_ESDHC_USE_PERIPHERAL_CLK
> do_fixup_by_compat_u32(blob, compat, "peripheral-frequency", @@ -
> 931,8 +940,6 @@ void fdt_fixup_esdhc(void *blob, bd_t *bd)
> do_fixup_by_compat_u32(blob, compat, "adapter-type",
> (u32)(gd->arch.sdhc_adapter), 1); #endif
> - do_fixup_by_compat(blob, compat, "status", "okay",
> - 4 + 1, 1);
> }
> #endif
>
> --
> 2.1.0.27.g96db324
More information about the U-Boot
mailing list