[U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Jul 4 19:48:36 UTC 2017


On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> 
> The code seems OK, but recently patches to add wdt-uclass has been
> posted:
> 
> http://patchwork.ozlabs.org/patch/751448/
> http://patchwork.ozlabs.org/patch/751451/
> 
> Maybe it would be better to port this driver to the uclass from the
> very beginning?

I started looking into this direction and have a question:
what the point to move to that class if it's broken from the beginning?

I really do not understand who on the earth would like to have
wdt_stop() at ->probe() (the only two users do exactly that!).

So, it looks to me now as bikeshedding, otherwise where is the
documentation which describes how this all stuff should work?

Can we go with the initial patch?

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the U-Boot mailing list