[U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier

[Tom Rini]

On Tue, Jul 04, 2017 at 10:48:36PM +0300, Andy Shevchenko wrote:
> On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> > 
> > The code seems OK, but recently patches to add wdt-uclass has been
> > posted:
> > 
> > http://patchwork.ozlabs.org/patch/751448/
> > http://patchwork.ozlabs.org/patch/751451/
> > 
> > Maybe it would be better to port this driver to the uclass from the
> > very beginning?
> 
> I started looking into this direction and have a question:
> what the point to move to that class if it's broken from the beginning?
> 
> I really do not understand who on the earth would like to have
> wdt_stop() at ->probe() (the only two users do exactly that!).

It's quite possible I'm just missing something, but I don't see it.  If
the uclass is totally broken, can you make a suggestion on fixing it?  I
can see a common case being "lets turn off the watchdog now" and not
want a wdt until the full OS, but we must also fully support "U-Boot has
and pets the Watchdog".

> So, it looks to me now as bikeshedding, otherwise where is the
> documentation which describes how this all stuff should work?
> 
> Can we go with the initial patch?

If it looks like some nightmare to fix the DM uclass, I suppose, but, is
it really that bad off atm?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170704/b839097c/attachment.sig>