[U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL

Bin Meng bmeng.cn at gmail.com
Sat Jul 22 12:59:29 UTC 2017


Hi Andy,

On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
> If ASL compiler failed by any reason do not produce output C file.
> Otherwise sequential run of make will shadow the actual error in ASL,
> i.e.
>
>   CC      board/intel/edison/dsdt.o
> board/intel/edison/dsdt.c:1:1: error: unterminated comment
>  /*
>
> and user has to remove dsdt.c and run make in order to see the error again.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  scripts/Makefile.lib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Although I am not sure how to reproduce "ASL compiler failed by any
reason do not produce output C file"..

Regards,
Bin


More information about the U-Boot mailing list