[U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL

[Andy Shevchenko]

On Sat, Jul 22, 2017 at 3:59 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Andy,
>
> On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
>> If ASL compiler failed by any reason do not produce output C file.
>> Otherwise sequential run of make will shadow the actual error in ASL,
>> i.e.
>>
>>   CC      board/intel/edison/dsdt.o
>> board/intel/edison/dsdt.c:1:1: error: unterminated comment
>>  /*
>>
>> and user has to remove dsdt.c and run make in order to see the error again.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>> ---
>>  scripts/Makefile.lib | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>

Thanks!

> Although I am not sure how to reproduce "ASL compiler failed by any
> reason do not produce output C file"..

Add

Name (XXX) ({

line to dsdt.asl for Minnowboard MAX and you will see

  ASL     board/intel/minnowmax/dsdt.asl
Compiler aborting due to parser-detected syntax error(s)
board/intel/minnowmax/dsdt.asl.tmp    739:  Name(XXX) ({
Error    6126 -                                    ^ syntax error,
unexpected PARSEOP_CLOSE_PAREN, expecting ','

Next run will get you above error (see commit message) which has been
quite confusing.

P.S. Of course it's artificial, but better to handle iasl (potential) failures.

-- 
With Best Regards,
Andy Shevchenko