[U-Boot] [PATCH v3 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Wed Jul 26 11:22:56 UTC 2017


Up to now, there's been some ugliness associated with the
dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.

Most platforms seem to have resorted to unconditionally enable
USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
patch for the RK3399 that did just that and rather decided to clean
this up once and for all instead of contributing to the prolongation
of the status quo).  Neither is a good solution.

So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
run moveconfig to contain the damage.

Changes in v3:
- rebased onto u-boot-usb/master at d2f6f70

Changes in v2:
- ran 'tabify' on newly added lines to fix a spaces vs. tabs issues

Philipp Tomsich (3):
  usb: gadget: move USB_FUNCTION_MASS_STORAGE to Kconfig
  Kconfig: CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE
  config: move USB_FUNCTION_MASS_STORAGE

 cmd/Kconfig                                    | 1 +
 configs/CHIP_pro_defconfig                     | 1 +
 configs/Nintendo_NES_Classic_Edition_defconfig | 1 +
 configs/Sinlinx_SinA33_defconfig               | 1 +
 configs/fennec-rk3288_defconfig                | 1 +
 configs/firefly-rk3288_defconfig               | 1 +
 configs/kylin-rk3036_defconfig                 | 1 +
 configs/miqi-rk3288_defconfig                  | 1 +
 configs/parrot_r16_defconfig                   | 1 +
 configs/phycore-rk3288_defconfig               | 2 +-
 configs/popmetal-rk3288_defconfig              | 1 +
 configs/smdkv310_defconfig                     | 1 +
 configs/tinker-rk3288_defconfig                | 1 +
 drivers/usb/gadget/Kconfig                     | 9 +++++++++
 include/configs/advantech_dms-ba16.h           | 1 -
 include/configs/apalis_imx6.h                  | 1 -
 include/configs/bav335x.h                      | 4 ----
 include/configs/cgtqmx6eval.h                  | 2 --
 include/configs/colibri_imx6.h                 | 1 -
 include/configs/colibri_imx7.h                 | 2 --
 include/configs/colibri_vf.h                   | 1 -
 include/configs/exynos4-common.h               | 2 --
 include/configs/ge_bx50v3.h                    | 1 -
 include/configs/gw_ventana.h                   | 1 -
 include/configs/ma5d4evk.h                     | 1 -
 include/configs/mx6sabre_common.h              | 2 --
 include/configs/mx7dsabresd.h                  | 2 --
 include/configs/nitrogen6x.h                   | 2 --
 include/configs/odroid_xu3.h                   | 1 -
 include/configs/opos6uldev.h                   | 1 -
 include/configs/pico-imx6ul.h                  | 1 -
 include/configs/pico-imx7d.h                   | 2 --
 include/configs/rk3036_common.h                | 1 -
 include/configs/rk322x_common.h                | 1 -
 include/configs/rk3288_common.h                | 1 -
 include/configs/s5p_goni.h                     | 1 -
 include/configs/socfpga_common.h               | 2 --
 include/configs/sunxi-common.h                 | 1 -
 include/configs/tbs2910.h                      | 1 -
 include/configs/tegra-common-usb-gadget.h      | 1 -
 include/configs/warp.h                         | 2 --
 include/configs/warp7.h                        | 2 --
 scripts/config_whitelist.txt                   | 1 -
 43 files changed, 22 insertions(+), 43 deletions(-)

-- 
2.1.4



More information about the U-Boot mailing list