[U-Boot] [PATCH 1/3] ae3xx: timer: Rename AE3XX to ATCPIT100

Simon Glass sjg at chromium.org
Fri Nov 24 22:36:16 UTC 2017


Hi Rick,

On 21 November 2017 at 00:27,  <rick at andestech.com> wrote:
>
>
>> -----Original Message-----
>> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
>> rick at andestech.com
>> Sent: Tuesday, November 21, 2017 2:40 PM
>> To: sjg at chromium.org; Open Source Project uboot
>> Cc: u-boot at lists.denx.de; dzu at denx.de
>> Subject: Re: [U-Boot] [PATCH 1/3] ae3xx: timer: Rename AE3XX to ATCPIT100
>>
>>
>> > -----Original Message-----
>> > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> > Sent: Monday, November 20, 2017 11:40 PM
>> > To: Open Source Project uboot
>> > Cc: U-Boot Mailing List; Wolfgang Denk; Detlev Zundel; Rick Jian-Zhi
>> > Chen(陳建
>> > 志)
>> > Subject: Re: [PATCH 1/3] ae3xx: timer: Rename AE3XX to ATCPIT100
>> >
>> > Hi,
>> >
>> > On 14 November 2017 at 19:48, Andes <uboot at andestech.com> wrote:
>> > > From: Rick Chen <rick at andestech.com>
>> > >
>> > > ATCPIT100 is Andestech timer IP which is embeded in AE3XX and AE250
>> > > boards. So rename AE3XX to
>> > > ATCPIT100 will be more make sence.
>> > >
>> > > Signed-off-by: Rick Chen <rick at andestech.com>
>> > > ---
>> > >  drivers/timer/Kconfig           |    7 ++-
>> > >  drivers/timer/Makefile          |    2 +-
>> > >  drivers/timer/ae3xx_timer.c     |  117 ---------------------------------------
>> > >  drivers/timer/atcpit100_timer.c |  117
>> > > +++++++++++++++++++++++++++++++++++++++
>> >
>> > If this is just a rename, why the big delta?
>> >
>>
>> I want to rename ae3xx_timer.c to atcpit100_timer.c By the way I also rename
>> function name and and struct name to let it more reasonable.
>> But I do not modify the code itself.
>>
>> Do you mean I shall not modify the content of atcpit100_timer.c ?
>> Or I can modify but I shall describe it more clear ?
>>
>
> Though the patch is not easy to see the differences.
> I tig it and list the delta for you reviewing

OK I see, thank you. Are you using 'patman' to submit the patches? It
should send this through as a proper delta.

Regards,
Simon


More information about the U-Boot mailing list