[U-Boot] [PATCH 2/6] cgtqmx6eval: Avoid calling setup_display() from SPL code

[Stefano Babic]

On 23/09/2017 04:45, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> There is no need call setup_display() from SPL code, so move it to
> board_init(), which executes only in U-Boot proper.
> 
> Reported-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>  board/congatec/cgtqmx6eval/cgtqmx6eval.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/congatec/cgtqmx6eval/cgtqmx6eval.c b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
> index 2ed66d3..d42cc94 100644
> --- a/board/congatec/cgtqmx6eval/cgtqmx6eval.c
> +++ b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
> @@ -683,8 +683,6 @@ int overwrite_console(void)
>  int board_early_init_f(void)
>  {
>  	setup_iomux_uart();
> -	setup_display();
> -
>  #ifdef CONFIG_MXC_SPI
>  	setup_spi();
>  #endif
> @@ -702,6 +700,8 @@ int board_init(void)
>  	else
>  		setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c_pad_info1);
>  
> +	setup_display();
> +
>  #ifdef CONFIG_SATA
>  	setup_sata();
>  #endif
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================