[U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err()

Simon Glass sjg at chromium.org
Mon Sep 25 02:15:39 UTC 2017


On 15 September 2017 at 23:10, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> U-Boot widely uses error() as a bit noisier variant of printf().
>
> This macro causes name conflict with the following line in
> include/linux/compiler-gcc.h:
>
>   # define __compiletime_error(message) __attribute__((error(message)))
>
> This prevents us from using __compiletime_error(), and makes it
> difficult to fully sync BUILD_BUG macros with Linux.  (Notice
> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)
>
> Let's convert error() into now treewide-available pr_err().
>
> Done with the help of Coccinelle, excluing tools/ directory.
>
> The semantic patch I used is as follows:
>
> // <smpl>
> @@@@
> -error
> +pr_err
>  (...)
> // </smpl>
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
> Changes in v2: None
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list