[U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err()

Masahiro Yamada yamada.masahiro at socionext.com
Thu Sep 28 06:11:05 UTC 2017


Hi Tom,

2017-09-16 14:10 GMT+09:00 Masahiro Yamada <yamada.masahiro at socionext.com>:
> U-Boot widely uses error() as a bit noisier variant of printf().
>
> This macro causes name conflict with the following line in
> include/linux/compiler-gcc.h:
>
>   # define __compiletime_error(message) __attribute__((error(message)))
>
> This prevents us from using __compiletime_error(), and makes it
> difficult to fully sync BUILD_BUG macros with Linux.  (Notice
> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)
>
> Let's convert error() into now treewide-available pr_err().
>
> Done with the help of Coccinelle, excluing tools/ directory.
>
> The semantic patch I used is as follows:
>
> // <smpl>
> @@@@
> -error
> +pr_err
>  (...)
> // </smpl>
>


Apparently, this is outdated already.

Do you want me to update this?
or will you run coccinelle by yourself?




-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list