[U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err()

[Tom Rini]

On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote:
> Hi Tom,
> 
> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada <yamada.masahiro at socionext.com>:
> > U-Boot widely uses error() as a bit noisier variant of printf().
> >
> > This macro causes name conflict with the following line in
> > include/linux/compiler-gcc.h:
> >
> >   # define __compiletime_error(message) __attribute__((error(message)))
> >
> > This prevents us from using __compiletime_error(), and makes it
> > difficult to fully sync BUILD_BUG macros with Linux.  (Notice
> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)
> >
> > Let's convert error() into now treewide-available pr_err().
> >
> > Done with the help of Coccinelle, excluing tools/ directory.
> >
> > The semantic patch I used is as follows:
> >
> > // <smpl>
> > @@@@
> > -error
> > +pr_err
> >  (...)
> > // </smpl>
> 
> 
> Apparently, this is outdated already.
> 
> Do you want me to update this?
> or will you run coccinelle by yourself?

Well, that was my first time running coccinelle, and it was rather
painless.  So yes, I'm happy to re-generate any coccinelle generated
patches so long as the smpl is included in the commit message.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170928/347085ad/attachment.sig>