[U-Boot] [PATCH 002/080] mpc83xx: spd_sdram: Fix whitespace style violations
Wolfgang Denk
wd at denx.de
Fri Sep 29 14:03:47 UTC 2017
Dear Mario,
In message <20170929125238.26226-2-mario.six at gdsys.cc> you wrote:
> Fix whitespace style violations in the MPC83xx SPD-SDRAM code.
...
> - ddr->csbnds[1].csbnds = ( (banksize(spd.row_dens) >> 8)
> - | ((banksize(spd.row_dens) >> 23) - 1) );
> ddr->cs_config[1] = ( 1<<31
> + ddr->csbnds[1].csbnds = ((banksize(spd.row_dens) >> 8)
> + | ((banksize(spd.row_dens) >> 23) - 1));
> | (odt_rd_cfg << 20)
> | (odt_wr_cfg << 16)
> | ((spd.nbanks == 8 ? 1 : 0) << 14)
> | ((spd.nrow_addr - 12) << 8)
This looks as if you were changing the code, and not only whitespace ?
I would expect that this does not even compile!
Which sort of testing did you give to this patch series?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A witty saying proves nothing, but saying something pointless gets
people's attention.
More information about the U-Boot
mailing list