[U-Boot] [PATCH v1 5/6] serial: stm32x7: add STM32F4 support
Bo Shen
voice.shen at gmail.com
Sat Sep 30 04:11:23 UTC 2017
Hi Patrice,
On 09/29/2017 04:52 AM, Patrice CHOTARD wrote:
>>> diff --git a/drivers/serial/serial_stm32x7.c
>>> b/drivers/serial/serial_stm32x7.c
>>> index 19697e3..44e8b42 100644
>>> --- a/drivers/serial/serial_stm32x7.c
>>> +++ b/drivers/serial/serial_stm32x7.c
>>> @@ -127,6 +127,7 @@ static int stm32_serial_probe(struct udevice *dev)
>>> #if CONFIG_IS_ENABLED(OF_CONTROL)
>>> static const struct udevice_id stm32_serial_id[] = {
>>> + { .compatible = "st,stm32-uart", .data = (ulong)&stm32f4_info},
>> s/st,stm32-uart/st,stm32f4-uart/ (?)
> We use the same DT bindings than kernel one and we want to keep aligned.
I'd suggest to send a patch to kernel to rename it.
> Historically stm32-uart is dedicated for F4, which was introduced first.
> And then with introduction of F7 and H7, new compatible string
> (stm32f7-uart and stm32h7-uart) was added.
If we have patch in kernel to rename it, then it will be more clear.
Best Regards,
Bo Shen
More information about the U-Boot
mailing list