[U-Boot] [PATCHv1 11/14] phy: bcm63xx: remove reset_free function

Dinh Nguyen dinguyen at kernel.org
Sat Apr 14 18:51:37 UTC 2018


The call to free the reset control line is a deadend call that doesn't
lead to any reset control functionality.

Also the reset_free() function will be remove in a subsequent patch, so
remove it here.

Signed-off-by: Dinh Nguyen <dinguyen at kernel.org>
---
 drivers/phy/bcm6318-usbh-phy.c | 4 ----
 drivers/phy/bcm6348-usbh-phy.c | 4 ----
 drivers/phy/bcm6358-usbh-phy.c | 4 ----
 drivers/phy/bcm6368-usbh-phy.c | 4 ----
 drivers/spi/bcm63xx_hsspi.c    | 4 ----
 drivers/spi/bcm63xx_spi.c      | 4 ----
 6 files changed, 24 deletions(-)

diff --git a/drivers/phy/bcm6318-usbh-phy.c b/drivers/phy/bcm6318-usbh-phy.c
index 6d54214..70907be 100644
--- a/drivers/phy/bcm6318-usbh-phy.c
+++ b/drivers/phy/bcm6318-usbh-phy.c
@@ -125,10 +125,6 @@ static int bcm6318_usbh_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	mdelay(100);
 
 	return 0;
diff --git a/drivers/phy/bcm6348-usbh-phy.c b/drivers/phy/bcm6348-usbh-phy.c
index 169ee0e..2cc04e1 100644
--- a/drivers/phy/bcm6348-usbh-phy.c
+++ b/drivers/phy/bcm6348-usbh-phy.c
@@ -77,10 +77,6 @@ static int bcm6348_usbh_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	return 0;
 }
 
diff --git a/drivers/phy/bcm6358-usbh-phy.c b/drivers/phy/bcm6358-usbh-phy.c
index e000316..0440388 100644
--- a/drivers/phy/bcm6358-usbh-phy.c
+++ b/drivers/phy/bcm6358-usbh-phy.c
@@ -77,10 +77,6 @@ static int bcm6358_usbh_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	return 0;
 }
 
diff --git a/drivers/phy/bcm6368-usbh-phy.c b/drivers/phy/bcm6368-usbh-phy.c
index 71abc0f..38dd5e0 100644
--- a/drivers/phy/bcm6368-usbh-phy.c
+++ b/drivers/phy/bcm6368-usbh-phy.c
@@ -165,10 +165,6 @@ static int bcm6368_usbh_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	/* enable usb_ref clock */
 	ret = clk_get_by_name(dev, "usb_ref", &clk);
 	if (!ret) {
diff --git a/drivers/spi/bcm63xx_hsspi.c b/drivers/spi/bcm63xx_hsspi.c
index 3393166..ddf75f0 100644
--- a/drivers/spi/bcm63xx_hsspi.c
+++ b/drivers/spi/bcm63xx_hsspi.c
@@ -383,10 +383,6 @@ static int bcm63xx_hsspi_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	/* initialize hardware */
 	writel_be(0, priv->regs + SPI_IR_MASK_REG);
 
diff --git a/drivers/spi/bcm63xx_spi.c b/drivers/spi/bcm63xx_spi.c
index f0df687..71bb07d 100644
--- a/drivers/spi/bcm63xx_spi.c
+++ b/drivers/spi/bcm63xx_spi.c
@@ -409,10 +409,6 @@ static int bcm63xx_spi_probe(struct udevice *dev)
 	if (ret < 0)
 		return ret;
 
-	ret = reset_free(&rst_ctl);
-	if (ret < 0)
-		return ret;
-
 	/* initialize hardware */
 	writeb_be(0, priv->base + regs[SPI_IR_MASK]);
 
-- 
2.7.4



More information about the U-Boot mailing list